Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up serializer -name serializer for polymorphic associations. #11235

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Tidy up serializer -name serializer for polymorphic associations. #11235

merged 2 commits into from
Aug 12, 2021

Conversation

MatthewKennedy
Copy link
Contributor

  • Use named serializer in polymorphic associations for cms_pages

@viezly
Copy link

viezly bot commented Aug 12, 2021 •
edited
Loading

Changes preview:

👀 Review pull request on Viezly

@MatthewKennedy
Copy link
Contributor Author

@damianlegawiec

This is possibly a cleaner way of achieving the fix for the unresolved serializer issue from the STI on cms_pages, what do yo think?

damianlegawiec
damianlegawiec approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@damianlegawiec damianlegawiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, less code duplication the better :)

@damianlegawiec damianlegawiec merged commit cf17dd6 into master Aug 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/alternitive-fix-for-sti-polymorphic-serialization branch August 12, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianlegawiec damianlegawiec damianlegawiec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthewKennedy @damianlegawiec