Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user account store credit display #11186

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

szymoniwacz
Copy link
Contributor

No description provided.

@szymoniwacz szymoniwacz requested a review from tomurb July 29, 2021 08:56
@viezly
Copy link

viezly bot commented Jul 29, 2021

Changes preview:

👀 Review pull request on Viezly

@@ -13,7 +13,7 @@

<div class="d-lg-inline-block account-page-user-info-item-store-credits">
<p class="my-0 text-uppercase text-center">
<%= Spree.t(:store_credit_name) %>: <b class="account-page-user-info-item-store-credits-amount"><%= Spree::Money.new(@user.total_available_store_credit(current_currency), currency: current_currency).to_s.gsub('.00', '') %></b>
<%= Spree.t(:store_credit_name) %>: <b class="account-page-user-info-item-store-credits-amount"><%= Spree::Money.new(@user.total_available_store_credit(current_currency, current_store), currency: current_currency).to_s.gsub('.00', '') %></b>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok, although later it could not call Spree::Money in here and use this
https://github.com/spree/spree/pull/11142/files#diff-cbe892c2336366a40b1f8a6f9bd28ebf8e7d1d1eb5f4a3223e475f69b841f56fR33
We need just to merge the mentioned PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomurb Yes, I don't wanted to duplicate you work in this pr.

@damianlegawiec damianlegawiec merged commit 0d92cc0 into master Jul 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the user-account-store-credit-display branch July 29, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants