Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix For Promotions Date Picker Failing Spec Test. #11090

Merged
merged 4 commits into from
Jun 7, 2021
Merged

Fix For Promotions Date Picker Failing Spec Test. #11090

merged 4 commits into from
Jun 7, 2021

Conversation

MatthewKennedy
Copy link
Contributor

@MatthewKennedy MatthewKennedy commented Jun 6, 2021 •
edited
Loading

Not sure if this will fix the Promo issue...

  • First test Run Initial PR - PASSED
  • Fix menu not updating in view if menu item is changed and visitor is navigating between Taxons. Tests passed CC issue.

@viezly
Copy link

viezly bot commented Jun 6, 2021 •
edited
Loading

Full changes overview:

Show details on Viezly ➡️

@damianlegawiec damianlegawiec merged commit 3f43ef2 into master Jun 7, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/promotion-spec branch June 7, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianlegawiec damianlegawiec damianlegawiec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthewKennedy @damianlegawiec