-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade select2-rails to 4.0 #10613
Upgrade select2-rails to 4.0 #10613
Conversation
Manage this branch in SquashTest this branch here: https://spark-solutionsupgrade-select2-t55g2.squash.io |
@przemosk I tried to update select2 to v4 -> https://github.com/MatthewKennedy/spree/tree/select2-v4 I remember battling away with this, I think I fixed it in the end. see if the js from tis file helps with the address fields. https://github.com/MatthewKennedy/spree/blob/select2-v4/backend/app/assets/javascripts/spree/backend/checkouts/edit.js |
@MatthewKennedy will take a look, thanks ! 😄 |
@przemosk You may need to use some of the view files here is the js relies on a change in those: Pick through the changes and see if there is anything in there that is helpful. |
d9f60a6
to
f905c61
Compare
d83d59e
to
fe9ff81
Compare
fe9ff81
to
aa64c7e
Compare
09151a8
to
cff9154
Compare
fe35cc4
to
f2a46ea
Compare
@@ -26,5 +26,5 @@ Gem::Specification.new do |s| | |||
|
|||
s.add_development_dependency 'rspec' | |||
# Temporary hack until https://github.com/wycats/thor/issues/234 is fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment still required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@poudelprakash nah, can be removed, feel free to submit a PR with this change
TODO:
customer
step in admin checkout values from fields are hidden byclear_address_fields()
js function, check why