Outstanding balance uses reimbursement #10411
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates outstanding_balance to use the value of "reimbursements" when determining the payment total.
Currently
outstanding_balance
(when a refund exists) is defined asBecause refunds are included in the
payment_total
here the outstanding balance ends up equalling the "order total minus your completed payment total, regardless of whether those payments have been refunded or not".In a couple scenarios this does not work as expected:
In this case the payment total will be double the order total and the order will show as refund owed.
In any scenario where the order is modified after payment is complete: