-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Order Notification Emails for Store Owner #10253
Feature: Order Notification Emails for Store Owner #10253
Conversation
…ecifying an email address in configurations > stores
Manage this branch in SquashTest this branch here: https://imdereknotify-store-owner-of-n-vr8kx.squash.io |
f4ede99
to
7a15294
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome @imderek 🚀 Could you fix the one migration issue and we could merge this!
core/db/migrate/20200607161221_add_store_owner_order_notification_delivered_to_spree_orders.rb
Outdated
Show resolved
Hide resolved
…n_delivered_to_spree_orders
@damianlegawiec One other thing. There's an older migration from 2014 that actually starts looking up and saving
This column obviously won't exist until my migration has run. Any suggestions for how I might address this? |
Hey @imderek You can wrap this validation in connection.column_exists?(:spree_stores, :new_order_notifications_email)
validates :new_order_notifications_email, email: { allow_blank: true }
end We need those migrations with proper dates, let's not jump back in time 😂 |
… reverted to current; validation only applies to model when col exists
00ab04d
to
c451a83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @imderek - thank you! 🎉
Resolves #10098.
This will give store owners the option to receive email notifications when new orders are placed.