Add prefix to regex terminals #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to check the terminal.
joerivv
reviewed
Oct 18, 2022
joerivv
approved these changes
Oct 18, 2022
|
@joerivv Thanks for merging. I will might submit some PR from time to time, depending on what issues arise in ClosedXML. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add prefixes to regex terminals to improve performance.
Some terminals yield have a measurable improvements, like sheet name of file name. The terminals have too non-distinct first chars, so there is basically no benefit to add a list of prefixes.
Resolves #161