Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-build for SBT 1.0.0 #74

Merged
merged 4 commits into from
Aug 15, 2017
Merged

Cross-build for SBT 1.0.0 #74

merged 4 commits into from
Aug 15, 2017

Conversation

liff
Copy link
Contributor

@liff liff commented Jun 5, 2017

Mainly to see how/if it works, I guess :)

Uses crossSbtVersions from SBT 0.13.16.

See also: #62.

@mielientiev
Copy link

@jrudolph when you can merge this PR?

@timothyklim
Copy link

@jrudolph any chance that this PR will be merged and released?

@jrudolph
Copy link
Member

There seems to be some demand, so we'll try to get to this sometime this week.

@ngbinh
Copy link

ngbinh commented Jul 18, 2017

+1 for this! Thanks

@liff
Copy link
Contributor Author

liff commented Jul 18, 2017

Updated for 1.0.0-RC2, which seems to allow src/main/scala-sbt-1.0 instead of the full binary version.

@liff liff changed the title Cross-build for SBT 1.0.0-M6 Cross-build for SBT 1.0.0-RC2 Jul 18, 2017
@jrudolph
Copy link
Member

Thanks, @liff. It basically seems to work for me. It seems that color logging is lost in 1.0.0-RC2, do you have seen this as well? Did the behavior of Logger.ansiCodesSupported change?

@liff
Copy link
Contributor Author

liff commented Jul 18, 2017

Didn't notice that, sorry. Looks like in 1.0.0-M6 and RC2 ansiCodesSupported is just false. A regression in SBT perhaps?

@liff
Copy link
Contributor Author

liff commented Jul 18, 2017

@jrudolph reported sbt/sbt#3336

@jrudolph
Copy link
Member

Thanks, I guess we might just ignore that for now and try to find out if that can be fixed in sbt.

@liff liff changed the title Cross-build for SBT 1.0.0-RC2 Cross-build for SBT 1.0.0-RC3 Jul 29, 2017
@liff
Copy link
Contributor Author

liff commented Jul 29, 2017

Updated. Color logging regression is fixed in 1.0.0-RC3.

@mielientiev
Copy link

mielientiev commented Aug 4, 2017

@jrudolph I believe after @liff fix we can merge it.
What do you think?

@martijnhoekstra
Copy link

@jrudolph just in case this escaped your attention and slipped through the cracks, there is hot demand, especially now that 1.0.0 final is out. A merge and release would be most appreciated

@jrudolph
Copy link
Member

jrudolph commented Aug 12, 2017 via email

@liff liff changed the title Cross-build for SBT 1.0.0-RC3 Cross-build for SBT 1.0.0 Aug 12, 2017
@jrudolph jrudolph merged commit 58c5b98 into spray:master Aug 15, 2017
@jrudolph
Copy link
Member

Thanks a lot, @liff. I tried it locally and it works perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants