Resolves #36 by introducing a culture-invariant DecimalInvariant parser #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine. |
mikehadlow
added a commit
that referenced
this pull request
Jun 23, 2015
Resolves #36 by introducing a culture-invariant DecimalInvariant parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd ideally like to change the signature of
Decimal()to accept aCultureInfo, but instead this PR goes for the non-breaking option of introducing a new parser using the*Invariantnaming convention found elsewhere in .NET. If nothing else, this should at least trigger caution when seen next toDecimalin IntelliSense.Bundled some minor test and ReSharper-guided cleanup, apologies for the cluttered diff. @mikehadlow any chance of a quick sanity check? Cheers! :-)