Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

markDeleted/unmarkDeleted #35

Merged
merged 5 commits into from
Dec 7, 2023
Merged

markDeleted/unmarkDeleted #35

merged 5 commits into from
Dec 7, 2023

Conversation

samek
Copy link
Contributor

@samek samek commented Oct 25, 2023

I've added markDeleted and unmarkDeleted which were missing in the java/com_spotify_voyager_jni_Index.cpp
Tests were also added for this addition.

dylanrb123
dylanrb123 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@dylanrb123 dylanrb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks for the PR!

@samek
Copy link
Contributor Author

samek commented Oct 25, 2023

  1. is there something else that I need to do - I see some of the checks are not successful (I did fix lints).
  2. I could squeeze in another commit with Java_com_spotify_voyager_jni_Index_resizeIndex also implemented and tested - and we would have all three which were TODO done.

@samek samek mentioned this pull request Oct 26, 2023
Merged
dylanrb123
dylanrb123 previously requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@dylanrb123 dylanrb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into the build failure, not 100% what's going on there. Also on second look, the tests could use some tweaks to better align with the rest of the assertions we have in the test suite.

java/src/test/java/com/spotify/voyager/jni/IndexTest.java Outdated Show resolved Hide resolved
@samek samek requested a review from dylanrb123 October 26, 2023 18:56
@markkohdev
Copy link
Contributor

Hey @samek sorry about the radio silence, we haven't forgotten about you! Just a lot going on as we come up to the end of the year. We're looking into why these GPG failures are happening and will hopefully have this merged soon

@psobot psobot mentioned this pull request Dec 5, 2023
Merged
@psobot psobot dismissed dylanrb123’s stale review December 5, 2023 21:54

Addressed comments

@psobot psobot merged commit f780757 into spotify:main Dec 7, 2023
52 checks passed
@samek samek deleted the markdelete branch January 24, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanrb123 dylanrb123 Awaiting requested review from dylanrb123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samek @markkohdev @dylanrb123 @psobot @sgabrovpop