Fix benchmarks failing and adjust compilation flags #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miclegr
changed the title
psobot
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
Looks great, thank you @miclegr! Just one note (really a TODO) about applying these same optimizations on Windows, although only ~4% of our daily installs are on Windows so we may be able to do that separately.
python/CMakeLists.txt
Outdated
Comment on lines
53
to
62
| # Allow for some math optimization on unix but not -ffast-math | ||
| # See: https://simonbyrne.github.io/notes/fastmath/#flushing_subnormals_to_zero | ||
| if (IS_UNIX) | ||
| add_compile_options(-fassociative-math -fno-signaling-nans -fno-trapping-math -fno-signed-zeros -freciprocal-math -fno-math-errno) | ||
| endif() | ||
|
|
||
| # Relase build on unix with all optimizations | ||
| if (CMAKE_BUILD_TYPE STREQUAL "Release" AND IS_UNIX) | ||
| add_compile_options(-O3) | ||
| endif() |
There was a problem hiding this comment.
A TODO for later - we should probably specify /Ox here when building for MSVC/Windows.
There was a problem hiding this comment.
Since it's trivial to add, I added it to this PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Three contributions in this PR:
-O3and some math optimization