Add LiveQueue method to enable ignoring of paused effects entirely #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan3d
approved these changes
Nov 29, 2023
nathan3d
approved these changes
Nov 29, 2023
togi
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds another way to set observers on a
LiveQueuesuch that all paused (aka background) effects are completely ignored.The main reason for this was a use case encountered where the developers do not care to listen to background effects (no paused listener was set) - but a crash was still happening due to the background queue size potentially exceeding the set limit.
This PR provides a way to completely ignore background effects without ever having to worry about the queue size exceeding size limits, while preserving all previous behavior.