[luigi.six.iteritems] usage removed #2834

drowoseque · 2019-11-25T18:34:41Z

Description

py27 tests removed from .travis.yml
luigi.six.iteritems eliminated
luigi.six.iteritems now raises exception on invocation to be sure it's not called

Motivation and Context

Have you tested this? If so, how?

tests are okay

drowoseque · 2019-11-25T18:40:50Z

@honnix
@dlstadther
it seems that travis can't be ran on branches differing from master
could you pls add py2-deprecation into /branches/only in travis.yml ?

honnix · 2019-11-25T18:46:24Z

@drowoseque added

luigi/six.py

luigi/tools/range.py

honnix · 2019-11-26T20:03:46Z

LGTM. PTAL as well @dlstadther @Tarrasch . We need some extra eyes. Not so sure of test coverage of those contrib code, so never know.

.travis.yml

drowoseque · 2019-11-30T10:39:23Z

@honnix
@dlstadther
ptal

honnix · 2019-12-02T09:34:38Z

Sorry I merged the snakebite PR first.

…teritems # Conflicts: # luigi/contrib/hdfs/snakebite_client.py # luigi/six.py

drowoseque · 2019-12-02T13:05:04Z

@honnix
i've resolved conflicts
could you, please review this pr
as well as @dlstadther or @Tarrasch

honnix · 2019-12-03T10:52:20Z

@drowoseque Please resolve the conflict. Thanks.

…teritems # Conflicts: # luigi/tools/luigi_grep.py

drowoseque · 2019-12-03T12:12:23Z

@honnix
done

* iteritems usage removed * no unused imports * bmo * bmo * iteritems removed * no doc for iteritems * most_common from collections.Counter * returning tuple * postgres toxenv for py3 * original * no-unused-import * F401 'luigi.six' imported but unused * blank line

* Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no six.{u,b} * joined * Update .travis.yml * "except ImportError" removed (#2845) * py2/py3 import error eliminated * E402 module level import not at top of file * E303 too many blank lines (3) * snakebite removed (#2833) * snamebite removed * no minicluster * no minicluster * flake8 * branches - master * no snakebite in tox.ini * [luigi.six.itervalues] usage removed (#2835) * no itervalues * no exception * [luigi.six.assertCountEqual] removed (#2841) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * six.assertCountEqual -> self.assertCountEqual * no ununsed import * E128 continuation line under-indented for visual indent * [luigi.six.next] removed (#2842) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no six.next * yield from instead of loop * too-many-blank-lines * `luigi.six.add_metaclass` removed (#2843) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * six.add_metaclass -> metaclass= * six.add_metaclass -> metaclass= * no `from __future__ import ...` (#2846) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no from __future__ import * [luigi.six.string_types] and [luigi.six.binary_type] removed (#2838) * no string_types * no-binary_type * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * original * no ununsed import * Update .travis.yml * Fix params hashing (#2540) * move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring * [luigi.mock.MockFile] removed (#2839) * no-mock-file * MockFile removed * unused import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * no string_types * no-binary_type * original * no ununsed import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * snakebite * no-unused-import * utf-8 in auth * no unused imports * py27 -> py37 in CONTRIBUTING.rst * E231 missing whitespace after ',' * [luigi.six.moves] removed (#2844) * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no-six-moves * del attr removed * del attr removed * exec_ removed * py 2.7 mentions removed from README and setup.py (#2852) * 2.7 mentions removed from README and setup.py * py27 -> py37 in CONTRIBUTING.rst * abstractproperty -> property + abstractmethod (#2847) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * abstractproperty -> property + abstractmethod * Update beam_dataflow.py * Update beam_dataflow.py * no-if-six.py* (#2840) * no-if-six.py* * no unused imports * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * postgres toxenv for py3 * postgres toxenv for py3 * postgres toxenv for py3 * \n * no-unused-import * test_multiple_workers back * F401 'luigi.six' imported but unused * test_url_without_basic_auth fix * [luigi.six.iteritems] usage removed (#2834) * iteritems usage removed * no unused imports * bmo * bmo * iteritems removed * no doc for iteritems * most_common from collections.Counter * returning tuple * postgres toxenv for py3 * original * no-unused-import * F401 'luigi.six' imported but unused * blank line * F401 'luigi.six' imported but unused * six.b('...') -> b'...' * blank line