Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TensorFlow #469

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Update TensorFlow #469

merged 1 commit into from
Jan 21, 2021

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Jan 20, 2021

  • Removed shapeless dependency
  • Compiles against 3.0.0-M3

nevillelyh
nevillelyh reviewed Jan 20, 2021
View reviewed changes
tensorflow/src/main/scala/com/spotify/featran/tensorflow/package.scala
implicit def tensorFlowFeatureBuilder: FeatureBuilder[tf.Example] = TensorFlowFeatureBuilder()

implicit val exampleFlatReader: FlatReader[tf.Example] = new FlatReader[tf.Example] {
import TensorFlowType._
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we were actually not using the shapeless based TensorFlowType[T] converters, just implicits/utilities from that package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, basically just utility methods from that package.

@codecov
Copy link

codecov bot commented Jan 21, 2021 •
edited
Loading

Codecov Report

Merging #469 (07fec19) into master (726f1dc) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
+ Coverage   97.52%   97.53%   +0.01%     
==========================================
  Files          55       55              
  Lines        1615     1623       +8     
  Branches       79       80       +1     
==========================================
+ Hits         1575     1583       +8     
  Misses         40       40
Impacted Files Coverage Δ
.../main/scala/com/spotify/featran/java/JavaOps.scala 100.00% <ø> (ø)
...scala/com/spotify/featran/tensorflow/package.scala 89.06% <100.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 726f1dc...07fec19. Read the comment docs.

@nevillelyh nevillelyh merged commit a402c31 into spotify:master Jan 21, 2021
@regadas regadas mentioned this pull request Jan 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevillelyh nevillelyh nevillelyh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@regadas @nevillelyh