Remove symlinks that point to build environment

[Jc2k]

Inspecting the final deb with dpkg-deb -c I can see a couple of symlinks to the build environment. This turns them into empty directories.

[Jc2k]

GitHub seems to have eaten our comments when I flattened the patch :-(? Hopefully you saw my explanation in an e-mail?

I have linked to the source of the issue within my fix_ function - it is expected behaviour in newer versions that virtualenv creates absolute links from this 'local' directory. But after the virtualenv is built we can replace them with symlinks, which the newer patch does.

Looking at the tests I don't think they will run at the moment on my version of deb python. I would fix them, but I can't figure out how you run them.

[jhermann]

See my pull request pypa/virtualenv#473. I had the same problem in a packaging tool, and don't know why they are absolute to start with.

[nailor]

Your comment is acutally available in Jc2k/dh-virtualenv@9b6bcd9

I think the patch looks fine otherwise, but could you add some tests for that method?

[Jc2k]

I'd be happy to add tests, but i'm not sure how to run them! Can you describe your setup? And I think the tests expect a different version of DebPython to what I have - so i think they might all fail for me?

[nailor]

Sorry for not responding this promptly.

Tests are currently just written to be run with nosetests, simple nosetests in the project root should run them. You'll need mock to be able to mock things.

[nailor]

I've set up a travis now, but unfortunately it does not try testing old pull requests.

Did you manage to test this change?

[Jc2k]

I've been running that branch on my buildbot since i did the original pull request, but i haven't had time to write the tests. Definitely still on my radar though.

[nailor]

I'm about to push out 0.7 version of this and symlink removal would probably make sense to be included. I'll try to look if I have some time to write tests on this, but of course highly appreciated if you come up with some :)

[mshytikov]

+1 I have the same issue with virtualenv (v1.11.4), so looking forward for 0.7
As a temporary workaround I'm using this:

# debian/rules

export DH_ALWAYS_EXCLUDE=<package_name_here>/local

%:
        dh $@ --with python-virtualenv

[jhermann]

See related #43