-
Notifications
You must be signed in to change notification settings - Fork 41
Support multiple controller view connections #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
=======================================
Coverage 94.37% 94.37%
=======================================
Files 43 42 -1
Lines 1279 1298 +19
=======================================
+ Hits 1207 1225 +18
- Misses 72 73 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
I like this idea 👍 |
45cfbb4 to
f83d084
Compare
a5c3753 to
b808554
Compare
b808554 to
be9f5eb
Compare
| /// May not be called while the loop is running. | ||
| /// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this still true even after the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is still true but I removed it because it duplicates information that already exists in the attention message
Following up on an idea that had been proposed.