Skip to content

Conversation

@kmcbride
Copy link
Collaborator

@kmcbride kmcbride commented Apr 30, 2021

Following up on an idea that had been proposed.

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #176 (73c71be) into master (9919fa8) will increase coverage by 0.00%.
The diff coverage is 97.72%.

❗ Current head 73c71be differs from pull request most recent head 3d20834. Consider uploading reports for the commit 3d20834 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #176   +/-   ##
=======================================
  Coverage   94.37%   94.37%           
=======================================
  Files          43       42    -1     
  Lines        1279     1298   +19     
=======================================
+ Hits         1207     1225   +18     
- Misses         72       73    +1     
Flag Coverage Δ
ios ?
macspm 94.37% <97.72%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
MobiusCore/Source/MobiusController.swift 98.36% <97.72%> (-0.33%) ⬇️
...rowableAssertion/Source/MobiusThrowableAssertion.m

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9919fa8...3d20834. Read the comment docs.

@rastersize
Copy link
Contributor

I like this idea 👍

@kmcbride kmcbride changed the title RFC: Support multiple controller connectables Support multiple controller connectables Apr 30, 2021
@kmcbride kmcbride marked this pull request as ready for review April 30, 2021 23:37
@kmcbride kmcbride closed this Dec 2, 2021
@kmcbride kmcbride reopened this Feb 12, 2025
@kmcbride kmcbride force-pushed the controller-connectables branch from 45cfbb4 to f83d084 Compare February 12, 2025 23:45
@kmcbride kmcbride changed the title Support multiple controller connectables Support multiple controller view connections Feb 12, 2025
@kmcbride kmcbride force-pushed the controller-connectables branch from a5c3753 to b808554 Compare February 13, 2025 16:54
@kmcbride kmcbride force-pushed the controller-connectables branch from b808554 to be9f5eb Compare February 13, 2025 18:00
Comment on lines -133 to -134
/// May not be called while the loop is running.
///
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this still true even after the change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is still true but I removed it because it duplicates information that already exists in the attention message

@kmcbride kmcbride merged commit aead153 into spotify:master Feb 14, 2025
2 checks passed
@kmcbride kmcbride deleted the controller-connectables branch February 14, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants