Fix and simplify logging adaptors #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
=======================================
Coverage 94.34% 94.34%
=======================================
Files 46 46
Lines 1290 1291 +1
=======================================
+ Hits 1217 1218 +1
Misses 73 73
Continue to review full report at Codecov.
|
Contributor
Author
|
Red because it reduces coverage by removing unnecessarily-long but well covered code |
jeppes
approved these changes
Apr 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through a series of unfortunate events,
Update.loggingwas refactored to a point where it didn’t actually work as far as the stack annotations are concerned.This implementation works, and is simpler and more uniform.
@jeppes