#549 Pass the auxiliary classpath using the -auxclasspathFromFile agument #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…File argument The plugin versions before 4.7.3.1 passed the auxiliary classpath via the standard input, which caused a deadlock during parallel builds with non-forked spotbugs. spotbugs#488 Although this was fixed by removing the -auxclasspathFromInput, this broke the classpath logic. The solution is to pass the classpath using a file.
corebonts
force-pushed
the
488-auxclasspath
branch
from
aca26bd
to
6a9bb44
Compare
hazendaz
reviewed
Feb 25, 2023
|
@corebonts bummer not seen in our integration tests. I suspected there was something more missing and had held over a comment related to original to do this. I know that was not enough but more of a marker for me that the original change may not have been entirely accurate. Would be nice to have a test confirmation here, is it possible you can get a test together on this and/or point out where we may have been testing this already but not verifying. Not sure if you are available to get back currently but would like to get release out as soon as possible. |
|
accepting as-is, will do more testing separately. |
|
Thank you for adding the tests #554 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin versions before 4.7.3.1 passed the auxiliary classpath via the standard input, which caused a deadlock during parallel builds with non-forked spotbugs. #488
Although this was fixed by removing the -auxclasspathFromInput, this broke the classpath logic.
The solution is to pass the classpath using a file.