This repository has been archived by the owner on Jun 11, 2021. It is now read-only.
Add SLI source defaults #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xabier Larrakoetxea <slok69@gmail.com>
Signed-off-by: Xabier Larrakoetxea <slok69@gmail.com>
Signed-off-by: Xabier Larrakoetxea <slok69@gmail.com>
Signed-off-by: Xabier Larrakoetxea <slok69@gmail.com>
Signed-off-by: Xabier Larrakoetxea <slok69@gmail.com>
Signed-off-by: Xabier Larrakoetxea <slok69@gmail.com>
Signed-off-by: Xabier Larrakoetxea <slok69@gmail.com>
Signed-off-by: Xabier Larrakoetxea <slok69@gmail.com>
Signed-off-by: Xabier Larrakoetxea <slok69@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8
This PR adds an optional flag to pass a configuration file that has the default backends for the SLI inputs. This way if an SLO does not have an SLI input information it can fallback t this configuration.
At this moment only the Prometheus backends are supported, so it only acts when there is no address defined for the Prometheus.
Other changes are for dependency updates including Kubernetes and Prometheus.