-
-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: Use XDG config directory on Linux #2514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements XDG Base Directory Specification compliance for Linux systems by changing the default config directory from ~/.spotdl
to ~/.config/spotdl
, while maintaining backward compatibility for existing users.
- Updates
get_spotdl_path()
to use XDG config directory (~/.config/spotdl
) on Linux - Implements backward compatibility logic to check for existing
~/.spotdl
directory - Maintains current behavior for non-Linux systems
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove import platformdirs
Co-authored-by: Jayden <23619946+Silverarmor@users.noreply.github.com>
Co-authored-by: Jayden <23619946+Silverarmor@users.noreply.github.com>
Co-authored-by: Jayden <23619946+Silverarmor@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for your submission!
In the future, please update documentation and ensure tests pass. Instructions in CONTRIBUTING.md
Description
This change updates the application to use the standard XDG config directory (
~/.config/spotdl
) on Linux, while maintaining backward compatibility for existing users.Related Issue
Closes #2387
Motivation and Context
This helps de-clutter the user's home folder on Linux and follows standard conventions, as requested in issue #2387.
How Has This Been Tested?
I have manually tested the following scenarios:
~/.config/spotdl
directory is created.~/.spotdl
directory is used if present.~/.config/spotdl
is prioritized if both directories exist.Screenshots (if appropriate)
Types of Changes
Checklist