Skip to content

Conversation

epignatelli
Copy link

@epignatelli epignatelli commented Mar 14, 2025

Description

This PR does two things:

  1. It improves the score filtering algorithm to identify the best candidates for a track. In particular:
    a. It removes the duration test. We now prefer extended mixes, and not exact length matches.
    b. It now checks whether the uploader of the track is the artist or the label, which should provide high reliability
  2. It modifies get_best_results to prefer longer tracks (extended mixes) to shorter ones (radio edits), which are usually the go-to for DJs.

Related Issue

#2181

Motivation and Context

Motivation is discussed in the corresponding issue, see #2181

How Has This Been Tested?

spotdl download https://open.spotify.com/track/1KcBNNtVhDcw5Xt7Do7n3F?si=3f1093cbd3234350 --audio youtube --log-level DEBUG

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

@epignatelli epignatelli marked this pull request as draft March 14, 2025 09:29
@epignatelli epignatelli changed the title feat: get_best_results now prioritises extended versions compared to … Prefer extended mixes to radio edits Mar 14, 2025
@epignatelli epignatelli marked this pull request as ready for review March 15, 2025 17:47
@Silverarmor
Copy link
Member

See #2181 (comment)

@Silverarmor Silverarmor added the Audio Matching Indicates an issue or pull request related to the process of url matching label Aug 1, 2025
@Silverarmor Silverarmor marked this pull request as draft August 1, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audio Matching Indicates an issue or pull request related to the process of url matching
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants