Skip to content

Normalization throws for relative path with colon ':' #550

Open
@Bubbis

Description

13] pry(main)> u = Addressable::URI.parse('../folder:2/readme.md')
=> #<Addressable::URI:0x1de84 URI:../folder:2/readme.md>
[14] pry(main)> u.normalize
Addressable::URI::InvalidURIError: Cannot assemble URI string with ambiguous path: 'folder:2/readme.md'
from /Users/bubbis/.local/share/mise/installs/ruby/3.3.7/lib/ruby/gems/3.3.0/gems/addressable-2.8.7/lib/addressable/uri.rb:2344:in `to_s'

I expect folder%2F2/readme.md and a successful return. Should that be the case? The issue would then point to the regex below which does not take the relative part into account which gets trimmed as per standard.

if self.scheme == nil && path =~ NORMPATH

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions