Merge pull request pingcap#1 from spongedu/hh

Fix Create StreamWindow
spongedu · Nov 29, 2018 · 86dd57d · 86dd57d
2 parents 72fc608 + 36c2704
commit 86dd57d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/parser.go b/parser.go
diff --git a/parser.y b/parser.y
@@ -4538,9 +4538,9 @@ SelectStmtFromTable:
 		}
 		if $7 != nil {
 		    if sw, ok := ($7.(*ast.StreamWindowSpec)); ok {
+		        st.StreamWindowSpec = sw
 		    } else {
-		    st.StreamWindowSpec = sw
-		    st.WindowSpecs = ($7.([]ast.WindowSpec))
+		        st.WindowSpecs = ($7.([]ast.WindowSpec))
 		    }
 		}
 		$$ = st

diff --git a/parser_test.go b/parser_test.go
@@ -2557,6 +2557,7 @@ func (s *testParserSuite) TestWindowFunctions(c *C) {
 		{`SELECT FIRST_VALUE(year) OVER (w ORDER BY year ASC) AS first FROM sales WINDOW w AS (PARTITION BY country);`, true},
 		{`SELECT RANK() OVER w1 FROM t WINDOW w1 AS (w2), w2 AS (), w3 AS (w1);`, true},
 		{`SELECT RANK() OVER w1 FROM t WINDOW w1 AS (w2), w2 AS (w3), w3 AS (w1);`, true},
+		{`SELECT COUNT(*) FROM st group by a window tumbling ( size 5 SECOND);`, true},
 	}
 	s.enableWindowFunc = true
 	s.RunTest(c, table)