Use maven-publish plugin for publishing #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the build's publishing from the old `maven` plugin to the new `maven-publish` plugin.
marcphilipp
force-pushed
the
stable-publishing
branch
from
3740e60 to
ee7058c
Compare
Codecov Report
@@ Coverage Diff @@
## master #950 +/- ##
============================================
+ Coverage 75.99% 76.01% +0.01%
- Complexity 3534 3535 +1
============================================
Files 377 377
Lines 10742 10742
Branches 1367 1367
============================================
+ Hits 8163 8165 +2
+ Misses 2102 2100 -2
Partials 477 477
Continue to review full report at Codecov.
|
leonard84
approved these changes
Nov 18, 2018
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
mkutz
pushed a commit
to mkutz/spock
that referenced
this pull request
May 29, 2019
This commit changes the build's publishing from the old `maven` plugin to the new `maven-publish` plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the build's publishing from the old
mavenplugin to the newmaven-publishplugin. Instead of callinguploadArchives, the newpublishlifecycle task is used on Travis. After initially converting theinternaldependencies tocompileOnlyones, I've completely removed them and the build seemed fine. Moreover, thespock-bomsubproject no longer publishes empty JAR artifacts.This change is