Add NamedParam support for groovy-2.5 with backport to 2.4

[leonard84]

This change is 

[codecov]

Codecov Report

Merging #921 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #921   +/-   ##
========================================
  Coverage      75.9%   75.9%           
  Complexity     3517    3517           
========================================
  Files           372     372           
  Lines         10687   10687           
  Branches       1356    1356           
========================================
  Hits           8112    8112           
  Misses         2104    2104           
  Partials        471     471

Impacted Files	Coverage Δ	Complexity Δ
...pock-core/src/main/java/spock/mock/MockingApi.java	2.94% <ø> (ø)	2 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0886296...424a003. Read the comment docs.

[szpak]

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @leonard84 and @marcphilipp)

---

spock-core/src/main/java/spock/mock/MockingApi.java, line 175 at r1 (raw file):

      @NamedParam(value = "verified", type = Boolean.class),
      @NamedParam(value = "useObjenesis", type = Boolean.class)
    })

Am I right that it will be just ignored on Groovy 2.4 (no extra check is done)?

[szpak]

Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @leonard84 and @marcphilipp)

[leonard84]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @szpak and @marcphilipp)

---

spock-core/src/main/java/spock/mock/MockingApi.java, line 175 at r1 (raw file):

Previously, szpak (Marcin Zajączkowski) wrote…

Am I right that it will be just ignored on Groovy 2.4 (no extra check is done)?

Yes, the JVM ignores all unknown annotations at runtime (JSR-175) so we have this compileOnly internal-backports project that provides these annotations so that we can compile on 2.4.

In any case the NamedParam annotations are just hints for the IDE, there are no additional checks. At least that is the current status, maybe groovy will add better checking capabilities later.

[szpak]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @marcphilipp)

[marcphilipp]

Should we mention that the backported annotations are just there so the code compiles and will not actually work?

[leonard84]

@marcphilipp how and where would you add this mention?

[marcphilipp]

In the Javadoc of the classes so it's at least clear to contributors and maintainers. 😉

[marcphilipp]

Thanks! 🙂