Set groovy minVersion to 2.5.0

[henrik242]

Done to support cases where 2.5.2 cannot be used: https://issues.apache.org/jira/browse/GROOVY-8779

See

• Spock can be compiled on JDK 10 [WIP] #862 (comment)
• a962d8c#r30465428

---

This change is 

[codecov]

Codecov Report

Merging #905 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #905   +/-   ##
========================================
  Coverage        75%     75%           
  Complexity     3439    3439           
========================================
  Files           371     371           
  Lines         10580   10580           
  Branches       1337    1337           
========================================
  Hits           7936    7936           
  Misses         2174    2174           
  Partials        470     470

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b58e0f1...7a962a4. Read the comment docs.

[MartyIX]

@henrik242 You have changed minGroovyVersion but not groovyVersion. Shoudn't groovyVersion be changed too? The thing is that Travis tests with 2.5.2 as it did before.

[henrik242]

@MartyIX No, groovyVersion does not need to be be changed. That way https://issues.apache.org/jira/browse/GROOVY-8710 is handled properly, at the same time as people seeing https://issues.apache.org/jira/browse/GROOVY-8779 can use the latest spock. (It works perfectly for me in a project with Java 10.0.2 and Groovy 2.5.1.)

[MartyIX]

But all Spock tests were run on 2.5.2 in Travis so you can't guarantee that it really works with 2.5.1 or 2.5.0. That's what confuses me.

[henrik242]

@MartyIX It really does work in my pretty large project with 800+ spock test files.

[MartyIX]

That's great. :)

[szpak]

@henrik242 I agree with @MartyIX that currently the Travis build doesn't check the codebase with Groovy 2.5.0. I know why changing it (groovyVersion) to 2.5.0 in general is a bad idea, but it would be good to test that case somehow.

Have you at least tried to build Spock with 2.5.0 (set as groovyVersion).

[henrik242]

I haven't tried it, but I guess building Spock with 2.5.0 might fail? At least I have tested thoroughly that using Spock works well with minVersion = 2.5.0

[szpak]

AFAIR the build fails.
Regarding just running tests, there is a jaxb issue mentioned here. Tests using it might fail in runtime (while using Spock with older Groovy with Java 9+). However, I haven't follow that topic.

[MartyIX]

@henrik242 The other way to solve your issue is to use Groovy 2.5.3 snapshot (stable version to be released in a week or so). It works with the latest RC of Spock and with the latest EAP version of IDEA (I don't use stable IDEA so I can't say anything about that.)

[henrik242]

@MartyIX Yeah, that's what I'm currently doing. No EAP is needed, though, the regular IDEA release works fine.

[leonard84]

fixed in 0c3c553