Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken links #787

Closed

Conversation

BurkHufnagel
Copy link
Contributor

Fixed broken links

Several of the hyperlinks in the documentation either went nowhere, or to the wrong location. This has been remedied.

@codecov
Copy link

codecov bot commented Oct 29, 2017

Codecov Report

Merging #787 into master will increase coverage by 0.02%.
The diff coverage is 82.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #787      +/-   ##
============================================
+ Coverage     74.36%   74.38%   +0.02%     
- Complexity     3212     3218       +6     
============================================
  Files           347      348       +1     
  Lines          9931     9964      +33     
  Branches       1233     1236       +3     
============================================
+ Hits           7385     7412      +27     
- Misses         2103     2107       +4     
- Partials        443      445       +2
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/spock/mock/DetachedMockFactory.java 100% <ø> (ø) 13 <0> (ø) ⬇️
...ava/org/spockframework/guice/GuiceInterceptor.java 88.23% <100%> (+1.13%) 11 <2> (+2) ⬆️
.../src/main/java/spock/mock/AutoAttachExtension.java 80% <80%> (ø) 4 <4> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d91bf78...35e28a8. Read the comment docs.

Copy link
Member

@leonard84 leonard84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, except for the one comment

@@ -17,13 +17,10 @@ https://github.com/spockframework/spock/tree/master/spock-tapestry/src/test/groo
== Unitils Module

Integration with the http://www.unitils.org/[Unitils] library. For examples see the specs in the
https://github.com/spockframework/spock/tree/master/spock-unitils/src/test/groovy/org/spockframework/unitils/dbunit[codebase].
https://github.com/spockframework/spock/tree/master/spock-unitils/src/test/groovy/org/spockframework/unitils[codebase].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is wrong with https://github.com/spockframework/spock/tree/master/spock-unitils/src/test/groovy/org/spockframework/unitils/dbunit ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... Looks like it's fine. I don't remember why I had to change it, but there doesn't seem to be a reason to do so now.

leonard84 added a commit that referenced this pull request Nov 22, 2017
@leonard84
Copy link
Member

Manually merged, thank you @BurkHufnagel

@leonard84 leonard84 closed this Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants