Skip to content

Fix broken background in PlantUML WBS diagrams#2310

Merged
leonard84 merged 2 commits intospockframework:masterfrom
leonard84:fix-parallel-exec-plantuml-diagrams
Feb 28, 2026
Merged

Fix broken background in PlantUML WBS diagrams#2310
leonard84 merged 2 commits intospockframework:masterfrom
leonard84:fix-parallel-exec-plantuml-diagrams

Conversation

@leonard84
Copy link
Member

@leonard84 leonard84 commented Feb 27, 2026

In newer PlantUML versions, BackgroundColor at the wbsDiagram {} level sets the diagram canvas background instead of the default node background. Move BackgroundColor (and RoundCorner) into node {} blocks so they correctly apply to nodes rather than the diagram canvas.

Summary by CodeRabbit

  • Documentation
    • Reorganized diagram styling structure in parallel execution documentation.

In newer PlantUML versions, BackgroundColor at the wbsDiagram {} level
sets the diagram canvas background instead of the default node background.
Move BackgroundColor (and RoundCorner) into node {} blocks so they
correctly apply to nodes rather than the diagram canvas.
@leonard84 leonard84 self-assigned this Feb 27, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 14afa54 and 997932b.

📒 Files selected for processing (1)
  • docs/parallel_execution.adoc

📝 Walkthrough

Walkthrough

Updates PlantUML diagram styling syntax in documentation by wrapping BackgroundColor and RoundCorner properties within node selector blocks. The change standardizes CSS-like styling structure for WBS diagrams without altering semantic values or documentation content.

Changes

Cohort / File(s) Summary
PlantUML Style Syntax Updates
docs/parallel_execution.adoc
Restructured style definitions across multiple diagrams by nesting BackgroundColor and RoundCorner properties inside node { ... } selector blocks, converting from top-level declarations to nested format.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 Hop hop, the styles now nest,
Node selectors pass the test,
Colors and corners wrapped so tight,
PlantUML diagrams shine so bright!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: fixing broken backgrounds in PlantUML WBS diagrams by restructuring style declarations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link

greptile-apps bot commented Feb 27, 2026

Greptile Summary

This PR fixes PlantUML WBS diagram rendering issues in the documentation by moving BackgroundColor and RoundCorner style properties from the wbsDiagram {} level into node {} blocks. In newer PlantUML versions, these properties at the diagram level affect the canvas background rather than node styling.

  • Consistently updated all PlantUML diagrams throughout docs/parallel_execution.adoc
  • No functional code changes, documentation-only update
  • Change ensures diagrams render correctly with newer PlantUML versions

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • Documentation-only change that fixes PlantUML diagram styling for compatibility. The changes are syntactically correct, consistently applied across all diagrams, and have no impact on actual code execution
  • No files require special attention

Important Files Changed

Filename Overview
docs/parallel_execution.adoc Moved PlantUML BackgroundColor and RoundCorner properties from wbsDiagram to node blocks for compatibility with newer PlantUML versions

Last reviewed commit: 997932b

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.13%. Comparing base (69ba918) to head (ac0f750).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2310   +/-   ##
=========================================
  Coverage     82.13%   82.13%           
- Complexity     4794     4795    +1     
=========================================
  Files           469      469           
  Lines         14954    14954           
  Branches       1888     1888           
=========================================
  Hits          12283    12283           
  Misses         1984     1984           
  Partials        687      687           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leonard84 leonard84 enabled auto-merge (squash) February 28, 2026 14:30
@leonard84 leonard84 merged commit 3c45983 into spockframework:master Feb 28, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants