Update to Gradle 9 #2202
Open
Update to Gradle 9 #2202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2202 +/- ##
============================================
- Coverage 81.90% 81.86% -0.05%
Complexity 4732 4732
============================================
Files 463 463
Lines 14767 14767
Branches 1869 1869
============================================
- Hits 12095 12089 -6
- Misses 1981 1987 +6
Partials 691 691 🚀 New features to boost your workflow:
|
Normally, the Spring Boot 2 Gradle Plugin would not be compatible with Gradle 9+ To get around this issue, we use the dependency-management plugin in isolation as described here: https://docs.spring.io/spring-boot/docs/2.7.7/gradle-plugin/reference/htmlsingle/#managing-dependencies.dependency-management-plugin.using-in-isolation This way, we get proper test execution and realistic version resolution on Gradle 9
Vampire
requested changes
Sep 1, 2025
| // as described here: https://docs.spring.io/spring-boot/docs/2.7.7/gradle-plugin/reference/htmlsingle/#managing-dependencies.dependency-management-plugin.using-in-isolation | ||
| // This way, we get proper test execution and realistic version resolution on Gradle 9 | ||
| id 'org.springframework.boot' version "2.7.18" apply false | ||
| id "io.spring.dependency-management" version "1.1.7" |
There was a problem hiding this comment.
How about instead removing the plugin from both places?
It is a relict from times when Gradle did not have built-in BOM support, by now does more harm than good, and even its maintainer recommends not to use it anymore, but instead the built-in BOM support using platform(...).
@leonard84 what do you think?
There was a problem hiding this comment.
I initially wanted this PR to be as non-invasive as possible which is why I opted for this variant.
I agree however that the bom variant would be much simpler.
Vampire
requested changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly regular maintenance.
The most interesting change is the setup of the Spring Boot 2 Gradle plugin (see 61dff17). Instead of applying it (which would lead to various compatibility issues), we just put it on the classpath and use the dependency-management plugin in isolation
as described here. This way we get proper test execution without even needing to apply the plugin.