Add check to prevent double global mocking #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this commit, it was possible to create a global GroovyMock/Stub/Spy for a type that was already a global mock, this is problematic and leaked the modified meta-class.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1792 +/- ##
=========================================
Coverage 79.87% 79.87%
- Complexity 4096 4100 +4
=========================================
Files 425 425
Lines 12967 12969 +2
Branches 1643 1644 +1
=========================================
+ Hits 10357 10359 +2
Misses 1998 1998
Partials 612 612
☔ View full report in Codecov by Sentry. |
leonard84
added a commit
that referenced
this pull request
Sep 15, 2023
This reverts commit 75ac394.
leonard84
added a commit
to leonard84/spock
that referenced
this pull request
Sep 15, 2023
Previous to this commit, it was possible to create a global GroovyMock/Stub/Spy for a type that was already a global mock, this is problematic and leaked the modified meta-class. (cherry picked from commit 75ac394)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this commit, it was possible to create a global
GroovyMock/Stub/Spy for a type that was already a global mock,
this is problematic and leaked the modified meta-class.