Prevent removal of ErrorSpecNode by Maven #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1447 +/- ##
============================================
- Coverage 79.52% 79.50% -0.02%
- Complexity 4005 4006 +1
============================================
Files 404 404
Lines 12546 12547 +1
Branches 1641 1641
============================================
- Hits 9977 9976 -1
- Misses 1974 1976 +2
Partials 595 595
Continue to review full report at Codecov.
|
The advantage is that in javadoc we can actually link to other methods easily, which also helps when working with the class in an IDE, because it allows navigation and pop-up javadoc for parent or otherwise related methods.
leonard84
previously approved these changes
Mar 14, 2022
leonard84
changed the title
leonard84
approved these changes
Mar 14, 2022
|
@kriegaex thanks for the PR |
This was referenced Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1444.
At the moment,
SpockEngineDiscoveryPostProcessor#processSpecNodecreates anErrorSpecNode(which implementsorg.junit.platform.engine.TestDescriptor) after catching errors thrown by extensions, which is then silently discarded by Maven Surefire because it filters fortestPlan.containsTests(). Therefore, we have to make sure thatcontainsTestsreturnstrue. An easy way to do that is to overridemayRegisterTests(). Another way would be to overrideisTest()instead, but actually neither an error node nor a spec actually is as test, they rather can contain tests.