Mocking in given block is ignored when mocked in setup method #962
Description
Issue description
Currently you can declare a certain mocked behaviour in the setup method, which will then be used for every test in the class. If you want to override that behaviour you HAVE to put it in the then block. This is very confusing to people as it is not the natural flow they would describe the test
How to reproduce
groovy example of a test
interface MyInterface {
int myMethod()
}
class MyInterfaceTest extends Specification {
def myInterface = Mock(MyInterface)
def setup() {
myInterface.myMethod() >> 1
}
def "testing regular behaviour"() {
when:
def result = myInterface.myMethod()
then:
result == 1
}
def "testing exceptional behaviour"() {
given:
myInterface.myMethod() >> 2
when:
def result = myInterface.myMethod()
then:
result == 2
}
}
Tests in words:
myMethod should always return 1
testing regular behaviour
When myMethod is called
Then the result is 1
testing exceptional behaviour
Given myMethod returns 2
When I call myMethod
Then the result is 2
In this case the second test will fail
You would have to write something like
def "testing exceptional behaviour"() {
when:
def result = myInterface.myMethod()
then:
_ * myInterface.myMethod() >> 2
result == 2
}
In words:
When I call myMethod
Then any call of myMethod returns 2
and the result is 2
To me the first wording of the test is a natural flow in comparison to the second version.
So my proposal is to add the given block to override the declarations of the setup-Method.
It is Important though, that the then-Block should still always win as you need to verify how often methods are called as well.