Replace .splunkrc with .env file in test and examples #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akaila-splunk
commented
Jan 11, 2022
akaila-splunk
commented
- replace .splunkrc file with .env in examples and test cases
- updated __init _.py and cmdopts classes method to support .env file
- created new .env file
- updated README.md file
- removed scripts and makefile commands use for creating .splunkrc file
- removed .splunkrc create steps from GitHub action for test
- Replace .spluncrc file with .env in examples and test cases - updated __init__.py and cmdopts classes method to support .env file
- Updated README.md file - removed scripts and makefile commands use for creating .splunkrc file - removed .splunkrc create steps from GitHub action for test
fantavlik
requested changes
Jan 19, 2022
fantavlik
approved these changes
Feb 1, 2022
Contributor
fantavlik
left a comment
fantavlik
left a comment
There was a problem hiding this comment.
Look good! This is working for me locally as well
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.