This repository was archived by the owner on May 10, 2018. It is now read-only.
PHP SDK: Infrastructure & Authentication #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
| * 'scheme' => (optional) The scheme to use: either "http" or "https". Defaults to "https". | ||
| * 'http' => (optional) An Http object that will be used for performing HTTP requests. | ||
| * } | ||
| */ |
There was a problem hiding this comment.
Might want to add a token field to this to allow people to pass tokens in from elsewhere. We added it later in Python, but it's trivial enough that you may as well do it now.
|
Okay, I've reviewed it. Can I go rock in the corner and cry now? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the first commits that setup the infrastructure for the PHP SDK.
In particular:
Please review to see if you have any issues with the overall structure & project organization.