Skip to content

Release/1.11.0 #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 63 commits into from
Mar 9, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
234773e
Add pagination support to history calls
luke-gumbley Mar 31, 2020
3e25776
Add create-react-app example and fix process.env assignment issue,
fantavlik Jun 30, 2020
851aac6
Make query input from user
fantavlik Jul 4, 2020
b96f50c
Rename Login to Inputs
fantavlik Jul 4, 2020
2f4a336
Ignore create-react-app example for jshint
fantavlik Jul 5, 2020
5293343
Add demo gif and rename to create-splunk-react-app
fantavlik Jul 8, 2020
fd1aba7
Updated HighCharts License.
rmaheshwari-splunk Jun 14, 2021
e31827b
Merge pull request #134 from splunk/master
vmalaviya-splunk Aug 5, 2021
5553034
Changes for sdk-app-collection and apps/local
vmalaviya-splunk Aug 10, 2021
c9f2e45
Updated docker-compose.yml and test.yml
vmalaviya-splunk Aug 10, 2021
5ba2ef9
Merge pull request #135 from splunk/DVPL-9708
vmalaviya-splunk Aug 11, 2021
9dec4e8
package-lock.json updated
ashah-splunk Aug 19, 2021
caa3d04
Update package-lock.json
ashah-splunk Aug 19, 2021
984fdf4
node 8 compatible mocha version
ashah-splunk Aug 19, 2021
b9eca50
Merge pull request #137 from splunk/DVPL-9896
ashah-splunk Aug 20, 2021
e0fa167
login example added
vmalaviya-splunk Aug 20, 2021
467400a
Update README.md
vmalaviya-splunk Aug 20, 2021
8a9b586
Update README.md
vmalaviya-splunk Aug 20, 2021
d4f2997
Change: admin -> username for token creation
vmalaviya-splunk Aug 23, 2021
697c0ad
Merge pull request #138 from splunk/DVPL-9897
ashah-splunk Aug 23, 2021
8ce8c39
Changes for savedsearch history pagination
vmalaviya-splunk Aug 30, 2021
971d655
Update service.js
vmalaviya-splunk Aug 31, 2021
1fcd003
Merge pull request #95 from luke-gumbley/patch-1
fantavlik Aug 31, 2021
fc69de2
Merge pull request #139 from splunk/DVPL-9933
vmalaviya-splunk Sep 1, 2021
d468ab3
Support added for output_mode for oneShotSearch
vmalaviya-splunk Sep 1, 2021
efd2a80
Add create-react-app example and fix process.env assignment issue,
fantavlik Jun 30, 2020
dede966
Make query input from user
fantavlik Jul 4, 2020
90089fb
Rename Login to Inputs
fantavlik Jul 4, 2020
68d7614
Ignore create-react-app example for jshint
fantavlik Jul 5, 2020
84df587
Add demo gif and rename to create-splunk-react-app
fantavlik Jul 8, 2020
43c4000
Update package.json
vmalaviya-splunk Sep 3, 2021
5e29e4f
Merge branch 'create-react-app' of https://github.com/splunk/splunk-s…
vmalaviya-splunk Sep 3, 2021
3614f83
Update SplunkJsExample.js
vmalaviya-splunk Sep 3, 2021
2dc3db3
Merge pull request #99 from splunk/create-react-app
fantavlik Sep 9, 2021
a24ab5f
oneShotSearch resolved
vmalaviya-splunk Sep 14, 2021
9206171
Modification for oneShotSearch:output_mode
vmalaviya-splunk Sep 15, 2021
d427999
Merge pull request #140 from splunk/DVPL-9898
vmalaviya-splunk Sep 15, 2021
c9b4f8e
Update
ashah-splunk Sep 21, 2021
b520a42
Rebase with develop
ashah-splunk Sep 21, 2021
70d87aa
Update README.md
ashah-splunk Sep 21, 2021
389dd8b
Update README.md
ashah-splunk Sep 21, 2021
71f4699
Updated HighCharts License.
rmaheshwari-splunk Jun 14, 2021
85d70ba
Update
ashah-splunk Sep 21, 2021
045343b
Update CREDITS.md
ashah-splunk Sep 21, 2021
4cef9d9
Merge branch 'DVPL-7223' of https://github.com/splunk/splunk-sdk-java…
ashah-splunk Sep 21, 2021
337f75e
Update README.md
ashah-splunk Sep 21, 2021
f6647ad
Merge pull request #119 from splunk/DVPL-7223
ashah-splunk Sep 24, 2021
b67c1c6
.conf CRUD support added
vmalaviya-splunk Nov 19, 2021
fee7c72
remove .cache files
vmalaviya-splunk Nov 19, 2021
18b07e8
Updated null check
vmalaviya-splunk Nov 19, 2021
26ce0c3
Refactored
vmalaviya-splunk Dec 1, 2021
b3fd917
Update context.js
vmalaviya-splunk Dec 1, 2021
b00bef3
Refactored
vmalaviya-splunk Dec 2, 2021
034e411
Structural changes for .conf CRUD functionality
vmalaviya-splunk Jan 5, 2022
422d4d6
Update README.md
vmalaviya-splunk Jan 5, 2022
7b54651
Refactoring
vmalaviya-splunk Jan 5, 2022
5fa52e6
README and test updated
vmalaviya-splunk Jan 7, 2022
381f8aa
Doc string added for new methods
vmalaviya-splunk Jan 7, 2022
5014298
Merge pull request #141 from splunk/DVPL-7124
vmalaviya-splunk Jan 10, 2022
4978bd3
Dependency updates
ashah-splunk Mar 3, 2022
c15c80b
package-lock.json updates
ashah-splunk Mar 3, 2022
8ad2273
Merge pull request #145 from splunk/dependency-updates
ashah-splunk Mar 4, 2022
050f39a
release/1.11.0 changes
vmalaviya-splunk Mar 7, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactoring
  • Loading branch information
vmalaviya-splunk committed Jan 5, 2022
commit 7b5465115ce070a0042f32d4ce0639bca409fac3
7 changes: 4 additions & 3 deletions lib/service.js
Original file line number Diff line number Diff line change
Expand Up @@ -1262,6 +1262,7 @@
this._load = utils.bind(this, this._load);
this.fetch = utils.bind(this, this.fetch);
this.create = utils.bind(this, this.create);
this.createAsync = utils.bind(this, this.createAsync);
this.list = utils.bind(this, this.list);
this.item = utils.bind(this, this.item);
this.instantiateEntity = utils.bind(this, this.instantiateEntity);
Expand Down Expand Up @@ -3144,7 +3145,7 @@
}
},

createAsync: async function (filename, stanza, keyValueMap, callback) {
createAsync: async function (filename, stanzaName, keyValueMap, callback) {
callback = callback || function() {};
var that = this;

Expand All @@ -3161,12 +3162,12 @@
}

// 3. Check if the stanza exists
var configStanza = await this.getStanza(configFile, stanza);
var configStanza = await this.getStanza(configFile, stanzaName);

// 4. If the stanza doesn't exist, create a new stanza with given keyValueMap
if(configStanza == undefined) {

configFile.create(stanza, keyValueMap, function (err, newStanza) {
configFile.create(stanzaName, keyValueMap, function (err, newStanza) {
callback();
});
}
Expand Down
4 changes: 2 additions & 2 deletions tests/service_tests/configuration.js
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ exports.setup = function (svc) {
var configs = svc.configurations(namespace);
configs.fetch(done);
},
async function (configs, done) {
function (configs, done) {
var keyValueMap = {}
keyValueMap[property1] = value1;
keyValueMap[property2] = value2;
Expand All @@ -180,7 +180,7 @@ exports.setup = function (svc) {
var invalidConfigFile = await configs.getConfFile("invalid_filename");
assert.ok(!invalidConfigFile);

// d. Stanza exists: Positive
// d. Stanza exists: Negative
var invalidConfigStanza = await configs.getStanza(configFile, "invalid_stanza_name");
assert.ok(!invalidConfigStanza);

Expand Down