Skip to content

Added support for node@8.17.0 for tests #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 21, 2021
Merged

Added support for node@8.17.0 for tests #128

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
22640b9
Initial commit to support for node@8.17.0
vmalaviya-splunk Jul 16, 2021
78849c6
Modify Mocha test cases to use 'BDD' interface
ashah-splunk Jul 16, 2021
ed443eb
Service tests added
vmalaviya-splunk Jul 16, 2021
adb46f3
beforeEach added
vmalaviya-splunk Jul 16, 2021
76f5849
Added support for node@8.17.0
vmalaviya-splunk Jul 20, 2021
6939be8
Update mocha-test.yml
vmalaviya-splunk Jul 20, 2021
7eac86b
Changes reverted fro sdk-app-collection
vmalaviya-splunk Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Changes reverted fro sdk-app-collection
  • Loading branch information
@vmalaviya-splunk
vmalaviya-splunk committed Jul 20, 2021
commit 7eac86bbd1572200c268f6e01f94023951249bd6
8 changes: 4 additions & 4 deletions tests/service_tests/savedsearch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ exports.setup = function (svc, loggedOutSvc) {
var updatedSearch = "search * | head 10";
var updatedDescription = "description";

var searches = this.service.savedSearches({ owner: this.service.username, app: "sdkappcollection" });
var searches = this.service.savedSearches({ owner: this.service.username, app: "sdk-app-collection" });

Async.chain([
function (done) {
Expand Down Expand Up @@ -234,7 +234,7 @@ exports.setup = function (svc, loggedOutSvc) {
var name = "jssdk_savedsearch_" + getNextId();
var originalSearch = "search index=_internal | head 1";

var searches = this.service.savedSearches({ owner: this.service.username, app: "sdkappcollection" });
var searches = this.service.savedSearches({ owner: this.service.username, app: "sdk-app-collection" });

Async.chain(
function (done) {
Expand Down Expand Up @@ -352,7 +352,7 @@ exports.setup = function (svc, loggedOutSvc) {
})

it("Callback#delete test saved searches", function (done) {
var searches = this.service.savedSearches({ owner: this.service.username, app: "sdkappcollection" });
var searches = this.service.savedSearches({ owner: this.service.username, app: "sdk-app-collection" });
searches.fetch(function (err, searches) {
var searchList = searches.list();
Async.parallelEach(
Expand Down Expand Up @@ -381,7 +381,7 @@ exports.setup = function (svc, loggedOutSvc) {
})

it("Callback#setupInfo succeeds", function (done) {
var app = new splunkjs.Service.Application(this.service, "sdkappcollection");
var app = new splunkjs.Service.Application(this.service, "sdk-app-collection");
app.setupInfo(function (err, content, app) {
// This error message was removed in modern versions of Splunk
if (err) {
Expand Down
2 changes: 1 addition & 1 deletion tests/service_tests/view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ exports.setup = function (svc) {

Async.chain([
function (done) {
service.views({ owner: "admin", app: "sdkappcollection" }).create({ name: name, "eai:data": originalData }, done);
service.views({ owner: "admin", app: "sdk-app-collection" }).create({ name: name, "eai:data": originalData }, done);
},
function (view, done) {
assert.ok(view);
Expand Down