Storagepassword's wildcard check for create and delete actions #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check for wildcards in 'app' and 'owner' while creating/removing a StoragePassword
vupadhyay
reviewed
Jul 11, 2022
vupadhyay
reviewed
Jul 11, 2022
vupadhyay
reviewed
Jul 11, 2022
| return super.remove(String.format("%s:%s:", realm, name)); | ||
| } | ||
|
|
||
| @Override | ||
| public Password remove(String key) { | ||
| if(checkForWildcards()){ |
There was a problem hiding this comment.
It might be missing context here, but why do we have to check for the wildcard when removing the password? What happens if I'm trying to remove a password that has - in it given that passwords with - have been allowed till now?
There was a problem hiding this comment.
we check for wildcards present in 'app' and 'owner' properties and not in the password itself. As we need 'app' and 'owner' values to determine from where the StoragePassword is being delete.
changed 'Boolean' to 'boolean'
vupadhyay
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check for presence of wildcard's in 'owner' and/or 'app' while creating or deleting a StoragePassword. Check and error message is kept consistent with the other SDKs.