-
Notifications
You must be signed in to change notification settings - Fork 122
CSPL-1337: Scheduler pipeline for App Framework #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff0e87e
to
3548573
Compare
sgontla
commented
Oct 21, 2021
jryb
reviewed
Oct 21, 2021
95d832b
to
e2a522c
Compare
jryb
approved these changes
Oct 25, 2021
smohan-splunk
approved these changes
Oct 26, 2021
gaurav-splunk
approved these changes
Oct 26, 2021
- Add scheduler for App framework: - Define Download, Pod copy and install phase, and their managers, to run in a decoupled way - Asynchronous channel writes active as interface for download, pod copy and install workers. - Periodically yield the reconcile, so that other CRs are not blocked for a long time - Update the phase status, across the reconciles, so that the App framework restarts from the place it left during the last reconcile
e2a522c
to
a7184e5
Compare
@@ -2646,6 +2646,29 @@ spec: | |||
type: object | |||
appName: | |||
type: string | |||
auxPhaseInfo: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it comes by default for all the CRs, as it is one data structure that is used for App Deploy info across the places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a Scheduler for the App framework
Code changes listed here add the following functionality:
Download
,Pod Copy
, andInstall
Phase Info
to track all the 3 phases of the scheduler. Also,Aux Phase Info
in the case of Standalone CRs, such that each Pod is tracked separately for the App package install status.