feat(health): Implement comprehensive health check endpoint #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 4, 2020 07:43
By default Splunk will enable SSL/TLS for splunkd (8089) and hec (8088). It can be desirable to offload encryption between pods to a the network layer using CNI and externally using ingress or istio. The following environment variables can be added to the operator deployment to disable default SSL/TLS This PR depends on splunk/docker-splunk#437 ref #185
This change aligns the container port names with the convention expected by common mesh solutions such as istio and linkerd format "identifier-proto" for example hec-https when tls mode is enabled and hec-http when disabled. The splunk web port has been removed from the indxer service definitions to be consistent with best practices where the UI is disabled on indexers. This change depends on #194 ref #194
This change implements a healthz enpoint (port 9000) allowing health check without starting a new process. Using the new healthz endpoint startup probes can be used to allow for slow starting search and indexer peer endpoints safely while still using readiness and liveness appropriatly. This change depends on docker edge PR splunk/docker-splunk#440
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements a healthz enpoint (port 9000) allowing health check without starting a new process. Using the new healthz endpoint startup probes can be used to allow for slow starting search and indexer peer endpoints safely while still using readiness and liveness appropriatly.
This change depends on docker edge PR splunk/docker-splunk#440
Merge after ref #195