Skip to content

Conversation

gabrielm-splunk
Copy link
Collaborator

@gabrielm-splunk gabrielm-splunk commented Sep 29, 2025

Description

This PR allows scope: cluster on standalone CRDs, and thus allowing to be installed in the /etc/deployment-apps dir

Key Changes

  • Modifying standalone CRDs to allow scope: cluster (as well as scope: local, where behavior is unchanged)
    • This will now allow us to install to /etc/deployment-apps

Testing and Verification

Ran operator and automation locally, however still in the process of manually verifying the changes. Just creating this PR to start getting review on work.

Related Issues

Jira: https://splunk.atlassian.net/browse/CSPL-3532
GHI: #1180

PR Checklist

  • Code changes adhere to the project's coding standards.
  • Relevant unit and integration tests are included.
  • Documentation has been updated accordingly.
  • All tests pass locally.
  • The PR description follows the project's guidelines.

@coveralls
Copy link
Collaborator

coveralls commented Sep 29, 2025

Pull Request Test Coverage Report for Build 18107063884

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 86.519%

Files with Coverage Reduction New Missed Lines %
pkg/splunk/enterprise/cp.go 1 36.11%
pkg/splunk/enterprise/afwscheduler.go 8 92.49%
Totals Coverage Status
Change from base Build 18040656546: -0.05%
Covered Lines: 10705
Relevant Lines: 12373

💛 - Coveralls

@rlieberman-splunk
Copy link
Collaborator

It would be good to add a test case to the appframeworksS1 test suite that includes an app deployed to the cluster scope, or possibly even add to one of the existing test cases with the cluster scope for a new app.

There are also some existing unit tests in standalone_test.go that are related to appframework that we should add to as well to test both the local and cluster scoped apps.

@kasiakoziol
Copy link
Collaborator

It would be good to add a test case to the appframeworksS1 test suite that includes an app deployed to the cluster scope, or possibly even add to one of the existing test cases with the cluster scope for a new app.

There are also some existing unit tests in standalone_test.go that are related to appframework that we should add to as well to test both the local and cluster scoped apps.

I agree. We need to add new test cases. Also, I believe that automated tests are not enough and some portion of manual tests is required for both local and cluster scopes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants