Skip to content

Conversation

kasiakoziol
Copy link
Collaborator

@kasiakoziol kasiakoziol commented Sep 11, 2025

Description

It addresses TODOs from #1550 and defines helm charts for IngestorCluster and enhances existing helm chart for IndexerCluster.

Key Changes

  • Handling missing values and defaults
  • Updating conf files only with changed values, not all of them at the same time
  • Helm charts
  • Tests

Testing and Verification

Automated and manual tests.

Related Issues

Jira: https://splunk.atlassian.net/browse/CSPL-3972

PR Checklist

  • Code changes adhere to the project's coding standards.
  • Relevant unit and integration tests are included.
  • Documentation has been updated accordingly.
  • All tests pass locally.
  • The PR description follows the project's guidelines.

@kasiakoziol kasiakoziol force-pushed the feature/CSPL-3551-ingestion-cr-todos branch from c3b3aa6 to 2af9061 Compare September 11, 2025 09:43
@coveralls
Copy link
Collaborator

coveralls commented Sep 11, 2025

Pull Request Test Coverage Report for Build 18184292699

Details

  • 241 of 263 (91.63%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 86.164%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/splunk/client/enterprise.go 7 9 77.78%
pkg/splunk/enterprise/ingestorcluster.go 125 133 93.98%
pkg/splunk/enterprise/indexercluster.go 108 120 90.0%
Files with Coverage Reduction New Missed Lines %
pkg/splunk/enterprise/indexercluster.go 3 74.59%
Totals Coverage Status
Change from base Build 17610018166: 0.07%
Covered Lines: 11234
Relevant Lines: 13038

💛 - Coveralls

@kasiakoziol kasiakoziol force-pushed the feature/CSPL-3551-ingestion-cr-todos branch from 8be83c4 to 053352d Compare September 18, 2025 10:09
@kasiakoziol kasiakoziol force-pushed the feature/CSPL-3551-ingestion-cr-todos branch 3 times, most recently from 237f20f to 546344f Compare September 23, 2025 06:07
@kasiakoziol kasiakoziol force-pushed the feature/CSPL-3551-ingestion-cr-todos branch from 546344f to 9c6cd69 Compare September 23, 2025 07:00
@kasiakoziol kasiakoziol force-pushed the feature/CSPL-3551-ingestion-cr-todos branch 2 times, most recently from f4dd945 to 20afef4 Compare September 30, 2025 10:53
@kasiakoziol kasiakoziol force-pushed the feature/CSPL-3551-ingestion-cr-todos branch from 20afef4 to 20d9d6c Compare October 1, 2025 08:12
@kasiakoziol kasiakoziol marked this pull request as ready for review October 1, 2025 08:15
@kasiakoziol kasiakoziol force-pushed the feature/CSPL-3551-ingestion-cr-todos branch 2 times, most recently from 93190a3 to e92092b Compare October 1, 2025 09:41
@kasiakoziol kasiakoziol force-pushed the feature/CSPL-3551-ingestion-cr-todos branch from e92092b to f9fb45a Compare October 1, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants