CSPL-3964: Upgrade operator sdk to 1.41.1 and Golang version to 1.24.4 #1574
Conversation
gabrielm-splunk
requested review from
Igor-splunk,
kasiakoziol,
patrykw-splunk,
rlieberman-splunk and
vivekr-splunk
|
I see the check for biased language is failing here, any insights on how to solve? There were very minimal changes and the only change that's included that has the biased word |
Pull Request Test Coverage Report for Build 18399762353Details
💛 - Coveralls |
We can add the go.mod file to https://github.com/splunk/splunk-operator/blob/main/.biased_lang_exclude. go.sum is already excluded. There's more information here if you need it too! https://github.com/splunk/biased-lang-linter/pkgs/container/biased_lang#excluding-directories-and-files |
Got it, done @rlieberman-splunk |
|
https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.40.0/:
https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.41.0/ |
| - develop | ||
| - main | ||
| - feature** | ||
| - CSPL-3964-upgrade-operator-sdk |
There was a problem hiding this comment.
Please remember to remove it before merge.
@kasiakoziol Yeah, I missed some of these. I was looking at a wrong version of the upgrade-sdk-version doc, will address today |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gabrielm-splunk
force-pushed
the
CSPL-3964-upgrade-operator-sdk
branch
from
a4416d1 to
a572a7d
Compare
gabrielm-splunk
force-pushed
the
CSPL-3964-upgrade-operator-sdk
branch
from
a572a7d to
cb364e3
Compare
There was a problem hiding this comment.
why do we need Cert-manager and Certificate resource?
…s we currently have as we work through adding real e2e testing.
…test binary in context.
gabrielm-splunk
force-pushed
the
CSPL-3964-upgrade-operator-sdk
branch
from
cb364e3 to
48a17ca
Compare
|
|
||
| "github.com/onsi/ginkgo/v2/types" | ||
| . "github.com/onsi/ginkgo/v2" | ||
| "github.com/onsi/ginkgo/v2/types" |
There was a problem hiding this comment.
looks like we can exclude this changes from test dir?
There was a problem hiding this comment.
Open question, does this MR should include certificate watcher changes?
I'm also wondering if Cert-manager specific resources from the upgrade guide should be included here.
Here is a reference
https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.40.0/
6 participants
Description
Upgrading operator-sdk to version 1.41.1 and Golang version to 1.24.4. There were some linting changes that trickled through, but were very minor, so just decided to leave in. Thankfully, there weren't any breaking changes, so this was pretty straightforward other than some go mod changes (ran
go mod tidyto resolve). This will help resolve security vulnerability: https://splunk.atlassian.net/browse/VULN-42799Key Changes
The main updates are in the
.envandDockerfileTesting and Verification
Ran operator locally, installed operator on EKS cluster, and ran unit tests. Added this branch to be picked up by integration testing, so will monitor outputs of that.
Related Issues
PR Checklist