Draft:CSPL-3675 Update Operator-SDK to v1.39 #1488
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 15271737043Details
💛 - Coveralls |
added 8 commits
April 14, 2025 11:06
…L-3675-operator-sdk # Conflicts: # .biased_lang_exclude
Igor-splunk
changed the title
added 2 commits
April 16, 2025 14:31
# Conflicts: # .env # go.mod
| @@ -63,7 +63,7 @@ var _ = BeforeSuite(func(ctx context.Context) { | |||
| By("bootstrapping test environment") | |||
|
|
|||
| testEnv = &envtest.Environment{ | |||
| CRDDirectoryPaths: []string{filepath.Join("..", "config", "crd", "bases")}, | |||
| CRDDirectoryPaths: []string{filepath.Join("..", "..", "config", "crd", "bases")}, | |||
There was a problem hiding this comment.
is it intentional?
There was a problem hiding this comment.
cmd/main.go
Outdated
| @@ -123,56 +125,56 @@ func main() { | |||
| os.Exit(1) | |||
| } | |||
|
|
|||
| if err = (&controllers.ClusterMasterReconciler{ | |||
| if err = (&controller2.ClusterMasterReconciler{ | |||
There was a problem hiding this comment.
Change this to splunk-controller instead.
| predicate.GenerationChangedPredicate{}, | ||
| predicate.AnnotationChangedPredicate{}, | ||
| common.GenerationChangedPredicate(), | ||
| common.AnnotationChangedPredicate(), |
There was a problem hiding this comment.
Come back to this change.
| err = ctrl.Watch( | ||
| source.Kind(mgr.GetCache(), instance, &handler.TypedEnqueueRequestForObject[splcommon.MetaObject]{}), | ||
| ) | ||
| //err = ctrl.Watch(&source.Kind{Type: instance}, &handler.EnqueueRequestForObject{}) |
There was a problem hiding this comment.
Remove commented line if not needed.
added 13 commits
May 6, 2025 11:19
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.33 migration
v1.34 migration
v1.36 migration
v1.38 migration NOT FULLY DONE
v1.39 migration