Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for password management #146

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Documentation for password management #146

merged 3 commits into from
Oct 9, 2020

Conversation

akondur
Copy link
Collaborator

@akondur akondur commented Oct 8, 2020

Added documentation for Password management.

  • Added a new file PasswordManagement.md which lists an introduction, describes usage of global kubernetes secret object, lists splunk secret tokens and some notes for the Splunk Admin
  • Added examples for CRUD operations in Examples.md
  • Added in-file and cross-file hyperlinks.
  • Edited some previous documentation on editing default admin password.

@akondur akondur force-pushed the document_password_management branch from 09101ad to 09918c2 Compare October 8, 2020 21:31
akondur
akondur commented Oct 8, 2020
View reviewed changes
docs/PasswordManagement.md Outdated Show resolved Hide resolved
sgontla
sgontla reviewed Oct 8, 2020
View reviewed changes
docs/Examples.md Outdated Show resolved Hide resolved
docs/PasswordManagement.md Outdated Show resolved Hide resolved
docs/Examples.md Outdated Show resolved Hide resolved
sgontla
sgontla reviewed Oct 8, 2020
View reviewed changes
docs/PasswordManagement.md Outdated Show resolved Hide resolved
@akondur akondur force-pushed the document_password_management branch 2 times, most recently from 0f72e25 to f1a6982 Compare October 8, 2020 23:42
gaurav-splunk
gaurav-splunk requested changes Oct 8, 2020
View reviewed changes
docs/Examples.md Outdated Show resolved Hide resolved
docs/Examples.md Outdated Show resolved Hide resolved
docs/PasswordManagement.md Outdated Show resolved Hide resolved
@akondur akondur force-pushed the document_password_management branch 2 times, most recently from 38ae39a to eaf9d36 Compare October 9, 2020 06:06
eddikay
eddikay suggested changes Oct 9, 2020
View reviewed changes
docs/PasswordManagement.md Outdated Show resolved Hide resolved
docs/Examples.md Outdated Show resolved Hide resolved
docs/Examples.md Outdated Show resolved Hide resolved
docs/Examples.md Outdated Show resolved Hide resolved
docs/Examples.md Outdated Show resolved Hide resolved
docs/PasswordManagement.md Outdated Show resolved Hide resolved
docs/PasswordManagement.md Outdated Show resolved Hide resolved
docs/PasswordManagement.md Outdated Show resolved Hide resolved
docs/PasswordManagement.md Outdated Show resolved Hide resolved
docs/PasswordManagement.md Outdated Show resolved Hide resolved
@akondur akondur force-pushed the document_password_management branch from eaf9d36 to 80235ea Compare October 9, 2020 19:31
kashok-splunk
kashok-splunk approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@kashok-splunk kashok-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@akondur akondur merged commit 3200357 into develop Oct 9, 2020
@romain-bellanger romain-bellanger mentioned this pull request Oct 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashok-splunk kashok-splunk kashok-splunk approved these changes

@smohan-splunk smohan-splunk smohan-splunk approved these changes

@gaurav-splunk gaurav-splunk gaurav-splunk approved these changes

@sgontla sgontla sgontla approved these changes

@eddikay eddikay eddikay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@akondur @kashok-splunk @smohan-splunk @gaurav-splunk @sgontla @eddikay