-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cspl-333, cspl-445, cspl-446, and cspl-448 #134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sgontla
commented
Sep 30, 2020
- Mounting the config to ../etc/apps/splunk-operator in case of standalone
- Mounting the config to ../etc/master-aps/splunk-operator in case of CM
- Multiple Remote end points
- Default option
- Additional Smartstore related config changes
- Reread the configuraiton on key change
sgontla
requested review from
kashok-splunk,
gaurav-splunk,
smohan-splunk and
akondur
September 30, 2020 20:44
sgontla
commented
Oct 1, 2020
gaurav-splunk
approved these changes
Oct 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now!
sgontla
force-pushed
the
smartstore_config_to_pods
branch
from
October 6, 2020 07:06
9dd8ee2
to
b64e4e7
Compare
sgontla
commented
Oct 6, 2020
sgontla
commented
Oct 6, 2020
akondur
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
kashok-splunk
approved these changes
Oct 7, 2020
smohan-splunk
approved these changes
Oct 7, 2020
Added changes to support: 1. Mounting the smartstore config to (1.A) ../etc/apps/splunk-operator in case of standalone (1.B) ../etc/master-apps/splunk-operator in case of Clustemaster 2. Issue Bundle push, in case of CM 3. Issue Pod Reset in case of Standalone 4. Multple remote volumes 5. Default config option 6. Cache Manager specific config 7. Re-Read the Smartstore config in case of S3 keys change 8. Decouple the Smartstore Config Map and the S3 secrete objects 9. Delete owner references before destroying the CR 10. Add a token to the Pod to check if the ConfigMap actually reflected to the Pod
sgontla
force-pushed
the
smartstore_config_to_pods
branch
from
October 7, 2020 02:51
4be98d2
to
635bacb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.