CSPL-465: Fix the updation of ConfigMap by adding resource version of ConfigMap as annotation in the CR #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ConfigMap as annotation in the CR
gaurav-splunk
requested review from
akondur,
kashok-splunk,
pdhanoya-splunk,
sgontla and
smohan-splunk
sgontla
reviewed
Sep 25, 2020
sgontla
suggested changes
Sep 25, 2020
sgontla
reviewed
Sep 30, 2020
sgontla
approved these changes
Sep 30, 2020
akondur
requested changes
Sep 30, 2020
kashok-splunk
approved these changes
Oct 1, 2020
smohan-splunk
approved these changes
Oct 1, 2020
akondur
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the case where if we try to update the
defaultssection in a CR thereby updating the default ConfigMap, pod should detect that change and should recycle so that it can come up with new configs. We solve this by annotating the CR with the Resource Version of the default ConfigMap. Any change in ConfigMap would lead to a new Resouce Version, thereby changing the pod template spec and hence resulting in the recycling of pod to pick up the latest changes.