Skip to content

Conversation

vzabawski
Copy link
Contributor

@vzabawski vzabawski commented Mar 30, 2022

Changes:

  • Add feature which allows skipping logs older than some specific time range

Proposed changes

New functionality allows skipping files older than some specific time range. This allows avoiding duplicated logs with path which contain wildcards.
Parameter description in fluentd docs: https://docs.fluentd.org/input/tail#limit_recently_modified

Types of changes

Changes only add new parameter. Without specifying this parameter, nothing changes in chart's behavior.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have read the CLA
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@vzabawski
Copy link
Contributor Author

This approach doesn't fully solve, but makes the situation with duplicated events mentioned in #728 a bit better.

@aryznar-splunk aryznar-splunk self-assigned this Apr 6, 2022
Copy link
Contributor

@hvaghani221 hvaghani221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also provide the same config in main values.yaml?

Changes:

- Add feature which allows skipping logs older than some specific time range
Copy link
Contributor

@hvaghani221 hvaghani221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!
Thanks

@hvaghani221 hvaghani221 merged commit 23edea6 into splunk:develop Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants