Skip to content

Conversation

hvaghani221
Copy link
Contributor

Fixing #621

@hvaghani221
Copy link
Contributor Author

I have rebased with develop.

Copy link
Contributor

@rockb1017 rockb1017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add aggrCustomFilters: to values.yaml so that user can specify a different custom filter.

@hvaghani221
Copy link
Contributor Author

hvaghani221 commented Dec 8, 2021

let's add aggrCustomFilters: to values.yaml so that user can specify a different custom filter.

There is already custom filter example in values.yaml file

# For example if you want to define a filter which sets cluster_name field to "my_awesome_cluster" you would the following filter
# <filter tail.containers.**>
# @type jq_transformer
# jq '.record.cluster_name = "my_awesome_cluster" | .record'
# </filter>
# This can be defined in the customFilters section as follows:
# ```
# customFilters:
# NamespaceSourcetypeFilter:
# tag: tail.containers.**
# type: jq_transformer
# body: jq '.record.cluster_name = "my_awesome_cluster" | .record'
# ```

It is same for all SCK plug-in. Same example would apply for this plugin as well.
What are your thoughts?

@hvaghani221 hvaghani221 requested a review from rockb1017 December 9, 2021 05:30
@chaitanyaphalak
Copy link
Contributor

I think @rockb1017 is right on this one, we need to differentiate between filters for metrics and metrics-agg

@hvaghani221
Copy link
Contributor Author

Hey @rockb1017, added customFiltersAggr config

@rockb1017 rockb1017 merged commit e86c881 into develop Dec 15, 2021
@rockb1017 rockb1017 deleted the sck-issue-621 branch December 15, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants