-
Notifications
You must be signed in to change notification settings - Fork 264
enabled custom filters in metric-aggr #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
39d9cd8
to
d8a62ec
Compare
I have rebased with develop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add aggrCustomFilters:
to values.yaml so that user can specify a different custom filter.
There is already custom filter example in values.yaml file splunk-connect-for-kubernetes/helm-chart/splunk-connect-for-kubernetes/values.yaml Lines 489 to 501 in d8a62ec
It is same for all SCK plug-in. Same example would apply for this plugin as well. What are your thoughts? |
I think @rockb1017 is right on this one, we need to differentiate between filters for metrics and metrics-agg |
Hey @rockb1017, added |
Fixing #621