Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change mechanism for component evaluation #6

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Change mechanism for component evaluation #6

merged 1 commit into from
Mar 29, 2019

Commits on Mar 29, 2019

  1. Change mechanism for component evaluation 

    Previously components were evaluated by creating a megacomponent that imported
JSON, YAML and JSONNET files. This provided little to no context for errors.

We change this to evaluate every component in its own jsonnet VM.
Processing components like this sequentially  leads to 30-40% overhead so we need to evaluate
components concurrently. This is done with a default concurrency of 5. The user
can change this number using the persistent `--eval-concurrency` flag.

This change reduces the time to evaluate a large set of components _and_ produces better messages
that have the failed component name when things do not load correctly.
    @gotwarlost
    gotwarlost committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    2c73882 View commit details
    Browse the repository at this point in the history