Add auto extract timestamp parameter support #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludovic-boutros
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
VihasMakwana
suggested changes
Oct 29, 2023
src/main/java/com/splunk/kafka/connect/SplunkSinkConnectorConfig.java
Outdated
Show resolved
Hide resolved
|
Looks good other than a couple of nits. Also, my CI has been failing lately so I'll merge it only after I get it green. Thanks for the change, @ludovic-boutros. Appreciate it! |
ludovic-boutros
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
|
@VihasMakwana It should be good now 👍 |
VihasMakwana
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
VihasMakwana
approved these changes
Nov 7, 2023
|
Thank you @VihasMakwana. |
|
@ludovic-boutros Released in 2.2.0, let me know if it's good for you. |
|
That's perfect, thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to enable the "auto extract timestamp" feature for a project.
This parameter is not exposed yet and therefore cannot be set on the HEC URI.
This PR expose this parameter.
It is not set by default to be keep compatibility with current behavior.
I have created a specific HEC URI builder in order to ease testing.